linux-kernel - Re: [PATCH] ipc/shm.c: removed 'int err' from shm_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181121210730.f820f51d03d1171d4319dc30@linux-foundation.org>
Date:   Wed, 21 Nov 2018 21:07:30 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     danielijrobson@...il.com
Cc:     dbueso@...e.de, manfred@...orfullife.com, ebiederm@...ssion.com,
        mike.kravetz@...cle.com, linux@...inikbrodowski.net,
        viro@...iv.linux.org.uk, ebiggers@...gle.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipc/shm.c: removed 'int err' from shm_get_policy()

On Sun, 18 Nov 2018 23:49:11 +0000 danielijrobson@...il.com wrote:

> removed unneeded variable in shm_get_policy()
> 
> ...
>
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -461,11 +461,10 @@ static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
>  {
>  	struct file *file = vma->vm_file;
>  	struct shm_file_data *sfd = shm_file_data(file);
> -	int err = 0;
>  
>  	if (sfd->vm_ops->set_policy)
> -		err = sfd->vm_ops->set_policy(vma, new);
> -	return err;
> +		return sfd->vm_ops->set_policy(vma, new);
> +	return 0;
>  }

Sorry, I don't think this is enough of an improvement to justify adding
the patch.