linux-kernel - Re: [PATCH] fuse: Add bad inode check in fuse_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegv8sfny0FG=DAb4AU3ecBYDG_WqVTVBCOt9HTVeQFNeaQ@mail.gmail.com>
Date:   Thu, 22 Nov 2018 10:20:56 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     mhjungk@...il.com
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: Add bad inode check in fuse_destroy_inode()

On Thu, Nov 22, 2018 at 12:18 AM Myungho Jung <mhjungk@...il.com> wrote:
>
> make_bad_inode() sets inode->i_mode to S_IFREG if I/O error is detected
> in fuse_do_getattr()/fuse_do_setattr(). If the inode is not a regular
> file, write_files and queued_writes in fuse_inode are not initialized
> and have NULL or invalid pointers written by other members in a union.
> So, list_empty() returns false in fuse_destroy_inode(). Add
> is_bad_inode() to check if make_bad_inode() was called.
>
> Reported-by: syzbot+b9c89b84423073226299@...kaller.appspotmail.com
> Signed-off-by: Myungho Jung <mhjungk@...il.com>

Thanks, applied.

Miklos