linux-kernel - Re: [PATCH][net-next] net: hinic: fix null pointer dereference on pointer hwdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7fe07c86-35c7-46d1-2d6e-dd3d4f0ff156@cogentembedded.com>
Date:   Thu, 22 Nov 2018 12:22:26 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Aviad Krawczyk <aviad.krawczyk@...wei.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] net: hinic: fix null pointer dereference on
 pointer hwdev

Hello!

On 21.11.2018 22:59, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer hwdev is being dereferenced when declaring hwif , however, later
> on hwdev is being null checked, hence we have dereference before null
> check error. Fix this by assigning hwiw and pdef only once hwdev has

    It's hwif, right?

> been null checked.
> 
> Detected by CoverityScan, CID#1485581 ("Dereference before null check")
> 
> Fixes: 4a61abb100c8 ("net-next/hinic:add rx checksum offload for HiNIC")
> 

    No need for this empty line.

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
[...]

MBR, Sergei