linux-kernel - Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181122105934.GA13325@infradead.org>
Date:   Thu, 22 Nov 2018 02:59:34 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Yehezkel Bernat <yehezkelshb@...il.com>, ashok.raj@...el.com,
        Mario Limonciello <Mario.Limonciello@...l.com>,
        michael.jamet@...el.com, Christian Kellner <ckellner@...hat.com>,
        rjw@...ysocki.net, Anthony Wong <anthony.wong@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        iommu@...ts.linux-foundation.org, lukas@...ner.de,
        jacob.jun.pan@...el.com, linux-pci@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-acpi@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices

On Thu, Nov 22, 2018 at 12:48:40PM +0200, Mika Westerberg wrote:
> We had an internal discussion regarding this and it was suggested that
> the new flag is called "is_untrusted" instead of "is_external". This
> covers Thunderbolt devices currently but can be extend to any other PCIe
> device such as "SD express" ones. When IOMMU is turned on it will then
> make sure devices with "is_untrusted" set are always using full IOMMU
> protection.
> 
> Any comments, objections? I was going to send v2 with this change
> included.

Sounds good to me as long as it goes along with a nice fat comment
explaining it.