linux-kernel - RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4211E93B707BEBADD5E5B63E80DB0@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Thu, 22 Nov 2018 11:01:56 +0000
From:   Aisheng DONG <aisheng.dong@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
CC:     "wg@...ndegger.com" <wg@...ndegger.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

[...]
> >> @@
> >> -1437,10 +1552,18 @@ static int __maybe_unused flexcan_suspend(struct
> >> device *device)
> >>  	int err = 0;
> >>
> >>  	if (netif_running(dev)) {
> >> -		err = flexcan_chip_disable(priv);
> >> -		if (err)
> >> -			return err;
> >> -		err = pm_runtime_force_suspend(device);
> >> +		/* if wakeup is enabled, enter stop mode
> >> +		 * else enter disabled mode.
> >> +		 */
> >> +		if (device_may_wakeup(device)) {
> >> +			enable_irq_wake(dev->irq);
> >> +			flexcan_enter_stop_mode(priv);
> >> +		} else {
> >> +			err = flexcan_chip_disable(priv);
> >> +			if (err)
> >> +				return err;
> >> +			err = pm_runtime_force_suspend(device);
> >
> > This is mixed with runtime pm.
> > I would suggestion you first upstream wakeup support.
> > Then runtime pm later separately.
> 
> In fact this patch is based on the patch "can: flexcan: Implement CAN Runtime
> PM", which is still under review, too.

Yes, please ignore rpm patch first.
This patch will be re-made and not depends on rpm for easy review.
After wakeup is ready, rpm patch will rebase on it.

Regards
Dong Aisheng

> 
> Marc
> 
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |