linux-kernel - Re: [PATCH] x86: fix -Wmissing-prototypes warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181122111458.GA107823@gmail.com>
Date:   Thu, 22 Nov 2018 12:14:58 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     wang.yi59@....com.cn
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        ard.biesheuvel@...aro.org, linux-efi@...r.kernel.org,
        pbonzini@...hat.com, rkrcmar@...hat.com, kvm@...r.kernel.org,
        jgross@...e.com, akataria@...are.com,
        virtualization@...ts.linux-foundation.org, m.mizuma@...fujitsu.com,
        peterz@...radead.org, prarit@...hat.com, douly.fnst@...fujitsu.com,
        dwmw@...zon.co.uk, luto@...nel.org, pasha.tatashin@...cle.com,
        rajvi.jingar@...el.com, zhe.he@...driver.com,
        akpm@...ux-foundation.org, dyoung@...hat.com,
        takahiro.akashi@...aro.org, ebiederm@...ssion.com, bhe@...hat.com,
        ivan.gorinov@...el.com, robh@...nel.org, andy.shevchenko@...il.com,
        frank.rowand@...y.com, jan.kiszka@...mens.com,
        jailhouse-dev@...glegroups.com, konrad.wilk@...cle.com,
        thomas.lendacky@....com, pravin.shedge4linux@...il.com,
        namit@...are.com, jroedel@...e.de, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org, keescook@...omium.org, anton@...msg.org,
        ccross@...roid.com, tony.luck@...el.com, rostedt@...dmis.org,
        kexec@...ts.infradead.org, robh+dt@...nel.org,
        frowand.list@...il.com, devicetree@...r.kernel.org,
        oleg@...hat.com, zhong.weidong@....com.cn, up2wing@...il.com
Subject: Re: [PATCH] x86: fix -Wmissing-prototypes warning


* wang.yi59@....com.cn <wang.yi59@....com.cn> wrote:

> Hi Ingo,
> 
> > * Yi Wang <wang.yi59@....com.cn> wrote:
> >
> > > We may get -Wmissing-prototypes warnings when building
> > > kernel with W=1, it's better to fix them as global function
> > > signature can be changed and caller who use the old unchanged
> > > prototypes will be hosed.
> > >
> > > This patch fixes most of -Wmissing-prototypes warnings which
> > > are in the root directory of arch/x86/kernel, not including
> > > the subdirectories.
> > >
> > > These are the warnings fixed in this patch:
> > > arch/x86/kernel/signal.c:865:17: warning: no previous prototype for ‘sys32_x32_rt_sigreturn’ [-Wmissing-prototypes]
> 
> ......
> 
> > >  include/linux/ftrace.h             | 3 +++
> > >  include/linux/kexec.h              | 1 +
> > >  include/linux/of_fdt.h             | 1 +
> > >  include/linux/ptrace.h             | 1 +
> > >  24 files changed, 55 insertions(+), 3 deletions(-)
> >
> > Breaks 32-bit compilation:
> >
> > ../arch/x86/include/asm/setup.h: Assembler messages:
> > ../arch/x86/include/asm/setup.h:30: Error: no such instruction: `unsigned long __startup_64(unsigned long physaddr,struct boot_params *bp)'
> >
> > I'll skip the setup.h bits - let's hope that's the only bug.
> 
> Sorry for the inconvenience, though I have checked carefully :-)
> 
> How do you produce this error? I tested this way but did not reproduce
> that error:
> # make allmodconfig
> # make -j8
> 
> Thanks for your time again!

I don't remember the exact config, but you could try the 32-bit 
allnoconfig and defconfig.

Note that the commands you used above will use the 64-bit kernel, not the 
32-bit kernel.

Thanks,

	Ingo