linux-kernel - Re: [PATCH] clocksource/drivers/integrator-ap: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEExFWvTCJ-k+54PGv7Ov5FRMpD1C2ZzzUxi4=Kbn_hrkmBmqw@mail.gmail.com>
Date:   Thu, 22 Nov 2018 22:39:26 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> On 22/11/2018 15:33, Frank Lee wrote:
> > On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
> > <daniel.lezcano@...aro.org> wrote:
> >>
> >> On 20/11/2018 14:18, Yangtao Li wrote:
> >>> use of_node_put() to release the refcount.
> >>>
> >>> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> >>
> >> Applied, thanks!
> > Hi Daniel：
> >
> > This patch is a bit small, I will resend。
>
> What do you mean by 'small' ?
        pri_node = of_find_node_by_path(path);
        if (node == pri_node){
                of_node_put(pri_node);

                /* The primary timer lacks IRQ, use as clocksource */
                return integrator_clocksource_init(rate, base);
        }

        sec_node = of_find_node_by_path(path);

Under my revision, pri_node and sec_nodeare the same thing.

Yours,
Yangtao
>
> >> --
> >>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >>
> >> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> >> <http://twitter.com/#!/linaroorg> Twitter |
> >> <http://www.linaro.org/linaro-blog/> Blog
> >>
>
>
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>