linux-kernel - Re: [net] xfrm_user: use xfrm_state_put to free xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181122144321.5gmyynui254qfeoq@gondor.apana.org.au>
Date:   Thu, 22 Nov 2018 22:43:21 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Mathias Krause <minipli@...glemail.com>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        Pan Bian <bianpan2016@....com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Pan Bian <bianpan2013@....com>
Subject: Re: [net] xfrm_user: use xfrm_state_put to free xfrm_state_alloc
 return value

On Wed, Nov 21, 2018 at 09:09:23PM +0100, Mathias Krause wrote:
> 
> -- >8 --
> 
> Subject: [PATCH] xfrm_user: fix freeing of xfrm states on acquire
> 
> Commit 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct
> xfrm_state") moved xfrm state objects to use their own slab cache.
> However, it missed to adapt xfrm_user to use this new cache when
> freeing xfrm states.
> 
> Fix this by introducing and make use of a new helper for freeing
> xfrm_state objects.
> 
> Fixes: 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct xfrm_state")
> Reported-by: Pan Bian <bianpan2016@....com>
> Cc: <stable@...r.kernel.org> # v4.18+
> Signed-off-by: Mathias Krause <minipli@...glemail.com>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Looks good to me.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt