linux-kernel - Re: [PATCH] scripts: use pkg-config to locate libcrypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d48cd5083490aa717f59c41960d5a02f93fce841.camel@infradead.org>
Date:   Thu, 22 Nov 2018 16:16:56 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Rolf Eike Beer <eb@...ix.com>,
        Linux Kernel Developers List <linux-kernel@...r.kernel.org>
Cc:     David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org
Subject: Re: [PATCH] scripts: use pkg-config to locate libcrypto

On Thu, 2018-11-22 at 16:45 +0100, Rolf Eike Beer wrote:
> -HOSTLDLIBS_sign-file = -lcrypto
> -HOSTLDLIBS_extract-cert = -lcrypto
> +HOSTLDLIBS_sign-file = $(shell $(PKG_CONFIG) --libs libcrypto 2> /dev/null || -lcrypto)
> +HOSTCFLAGS_extract-cert.o = $(shell $(PKG_CONFIG) --cflags libcrypto 2> /dev/null)
> +HOSTLDLIBS_extract-cert = $(shell $(PKG_CONFIG) --libs libcrypto 2> /dev/null || -lcrypto)


Looks good; thanks. But could you put it into intermediate
CRYPTO_CFLAGS and CRYPTO_LIBS variables instead of calculating the
latter in two separate callouts? 

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)