linux-kernel - Re: [PATCH 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a386850a-6fe9-9cd6-72dd-c00e09405d51@deltatee.com>
Date:   Thu, 22 Nov 2018 09:54:41 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Wesley Sheng <wesley.sheng@...rochip.com>,
        kurt.schwemmer@...rosemi.com, jdmason@...zu.us,
        dave.jiang@...el.com, allenbh@...il.com, linux-pci@...r.kernel.org,
        linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org
Cc:     wesleyshenggit@...a.com
Subject: Re: [PATCH 0/3] ntb_hw_switchtec: Added support of >=4G memory
 windows

Hey,

This entire series looks good to me.

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

Logan

On 2018-11-22 2:01 a.m., Wesley Sheng wrote:
> Hi, Everyone,
> 
> This patch series adds support of >=4G memory windows.
> 
> Current Switchtec's BAR setup registers are limited to 32bits,
> corresponding to the maximum MW (memory window) size is <4G.
> Increase the MW sizes with the addition of the BAR Setup Extension
> Register for the upper 32bits of a 64bits MW size. This increases the MW
> range to between 4K and 2^63.
> 
> Additionally, we've made the following changes:
> 
> * debug print 64bit aligned crosslink BAR numbers
> * Fix the array size of NT req id mapping table
> 
> Tested with ntb_test.sh successfully based on NTB fixes series from
> Logan Gunthorpe <logang@...tatee.com> at 
> https://github.com/sbates130272/linux-p2pmem on branch of
> ntb_multiport_fixes
> 
> Regards,
> Wesley
> 
> 
> 
> Paul Selles (2):
>   ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers
>   ntb_hw_switchtec: Added support of >=4G memory windows
> 
> Wesley Sheng (1):
>   ntb_hw_switchtec: NT req id mapping table register entry number should
>     be 512
> 
>  drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 11 ++++++++---
>  include/linux/switchtec.h              | 10 +++++++---
>  2 files changed, 15 insertions(+), 6 deletions(-)
>