linux-kernel - Re: [PATCH 1/2] spi: mediatek: Add bindings for mediatek MT7629 soc platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1542937800.27607.27.camel@mhfsdcap03>
Date:   Fri, 23 Nov 2018 09:50:00 +0800
From:   lei liu <leilk.liu@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
CC:     Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-spi@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <ryder.lee@...iatek.com>
Subject: Re: [PATCH 1/2] spi: mediatek: Add bindings for mediatek MT7629 soc
 platform

On Tue, 2018-11-20 at 11:28 +0100, Matthias Brugger wrote:
> 
> On 20/11/2018 09:41, Leilk Liu wrote:
> > This patch adds a DT binding documentation for the MT7629 soc.
> > 
> > Signed-off-by: Leilk Liu <leilk.liu@...iatek.com>
> > ---
> >  .../devicetree/bindings/spi/spi-mt65xx.txt         |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > index 7940940..6cc4e87 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -6,6 +6,7 @@ Required properties:
> >      - mediatek,mt2712-spi: for mt2712 platforms
> >      - mediatek,mt6589-spi: for mt6589 platforms
> >      - mediatek,mt7622-spi: for mt7622 platforms
> > +    - mediatek,mt7629-spi: for mt7629 platforms
> 
> That's ok, as you add support in the driver. As it actually doesn't change
> anything in the driver itself you could just describe the binding as something like:
> " mediatek,mt7629-spi", "mediatek,mt7622-spi": for mt7629 platforms
> 
> This way the driver will just probe the driver using the fallback (mt7622)
> compatible, but if you realize in the future that you will need to distinguish
> between the two SoCs, you can add a mt7629 compatible.
> 
> Just as information for the future :)
> 

Got it, thanks for your advice and information :)

> Regards,
> Matthias