linux-kernel - Re: [PATCH] drm/meson: add support for 1080p25 mode

Open Source and information security mailing list archives

Date:   Fri, 23 Nov 2018 13:57:00 +0100
From:   Michal Lazo <michal.lazo@...agon.org>
To:     narmstrong@...libre.com
Cc:     christianshewitt@...il.com, airlied@...ux.ie, khilman@...libre.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        carlo@...one.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm/meson: add support for 1080p25 mode

I would suggest same aproach as for
"meson_hdmi_encp_mode_1080p30"
and "meson_hdmi_encp_mode_1080p60"

so duplicate "meson_hdmi_encp_mode_1080p50"
with name "meson_hdmi_encp_mode_1080p25"

now the code looks really like common copy paste problem
Michal Lazo
On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@...libre.com> wrote:
>
> On 21/11/2018 10:39, Christian Hewitt wrote:
> > This essential mode for PAL users is missing, so add it.
> >
> > Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> > ---
> >  drivers/gpu/drm/meson/meson_venc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> > index acbbad3..ab16046 100644
> > --- a/drivers/gpu/drm/meson/meson_venc.c
> > +++ b/drivers/gpu/drm/meson/meson_venc.c
> > @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> >       { 5, &meson_hdmi_encp_mode_1080i60 },
> >       { 20, &meson_hdmi_encp_mode_1080i50 },
> >       { 32, &meson_hdmi_encp_mode_1080p24 },
> > +     { 33, &meson_hdmi_encp_mode_1080p50 },
> >       { 34, &meson_hdmi_encp_mode_1080p30 },
> >       { 31, &meson_hdmi_encp_mode_1080p50 },
> >       { 16, &meson_hdmi_encp_mode_1080p60 },
> >
>
> Exact, I forgot this mode...
>
> Thanks for the change !
>
> Acked-by: Neil Armstrong <narmstrong@...libre.com>
>
> I'll add :
> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
> when applying to drm-misc-fixes.
>
> Neil
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic


-- 
Best Regards

Michal Lazo
Senior developer engineer
mdragon.org
Slovakia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives