linux-kernel - Re: [PATCH 02/11] mfd: da9055-core: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181123031456.GD14659@windriver.com>
Date:   Thu, 22 Nov 2018 22:14:57 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     kbuild test robot <lkp@...el.com>
CC:     <kbuild-all@...org>, Lee Jones <lee.jones@...aro.org>,
        <linux-kernel@...r.kernel.org>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 02/11] mfd: da9055-core: make it explicitly non-modular

[Re: [PATCH 02/11] mfd: da9055-core: make it explicitly non-modular] On 23/11/2018 (Fri 10:21) kbuild test robot wrote:

> Hi Paul,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v4.20-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Paul-Gortmaker/mfd-simple-demodularization-of-non-modular-drivers/20181123-090206
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: i386-randconfig-s1-11191736 (attached as .config)
> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/mfd/da9055-i2c.o: In function `da9055_i2c_remove':
> >> drivers/mfd/da9055-i2c.c:53: undefined reference to `da9055_device_exit'

Thanks for the report -- I'll look into what causes it, why my testing
didn't see it, and get an update to Lee as soon as possible.

Paul.
--

> 
> vim +53 drivers/mfd/da9055-i2c.c
> 
> 2896434c Ashish Jangam  2012-09-14  48  
> 4740f73f Bill Pemberton 2012-11-19  49  static int da9055_i2c_remove(struct i2c_client *i2c)
> 2896434c Ashish Jangam  2012-09-14  50  {
> 2896434c Ashish Jangam  2012-09-14  51  	struct da9055 *da9055 = i2c_get_clientdata(i2c);
> 2896434c Ashish Jangam  2012-09-14  52  
> 2896434c Ashish Jangam  2012-09-14 @53  	da9055_device_exit(da9055);
> 2896434c Ashish Jangam  2012-09-14  54  
> 2896434c Ashish Jangam  2012-09-14  55  	return 0;
> 2896434c Ashish Jangam  2012-09-14  56  }
> 2896434c Ashish Jangam  2012-09-14  57  
> 
> :::::: The code at line 53 was first introduced by commit
> :::::: 2896434cf272acace1b7093d5e4ba8022ed11ac8 mfd: DA9055 core driver
> 
> :::::: TO: Ashish Jangam <ashish.jangam@...tcummins.com>
> :::::: CC: Samuel Ortiz <sameo@...ux.intel.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation