linux-kernel - Re: [PATCH] dma: coh901318: Fix a double-lock bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181124143035.GJ3175@vkoul-mobl.Dlink>
Date:   Sat, 24 Nov 2018 20:00:35 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     linus.walleij@...aro.org, dan.j.williams@...el.com,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: coh901318: Fix a double-lock bug

On 06-11-18, 11:33, Jia-Ju Bai wrote:
> The function coh901318_alloc_chan_resources() calls spin_lock_irqsave() 
> before calling coh901318_config().
> But coh901318_config() calls spin_lock_irqsave() again in its
> definition, which may cause a double-lock bug.
> 
> Because coh901318_config() is only called by
> coh901318_alloc_chan_resources(), the bug fix is to remove the
> calls to spin-lock and -unlock functions in coh901318_config().

Applied after fixing subsystem tag, thanks
-- 
~Vinod