linux-kernel - Re: [PATCH] devres: no print device_node.name in devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEExFWvods_59FKDpzFH9a3ifYd58CAXt3CraP7EebUUVd5n2w@mail.gmail.com>
Date:   Sat, 24 Nov 2018 22:56:39 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     robh@...nel.org, gregkh@...uxfoundation.org, rafael@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] devres: no print device_node.name in devres_log()

On Sat, Nov 24, 2018 at 10:25 PM Yangtao Li <tiny.windzz@...il.com> wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> avoid to printf node name.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/base/devres.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 4aaf00d2098b..34c07e9faaf9 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct devres_node *node,
>                        const char *op)
>  {
>         if (unlikely(log_devres))
> -               dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
> -                       op, node, node->name, (unsigned long)node->size);
The modification of this place is a bit problematic, ignoring this email.

Yours,
Yangtao
> +               dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
> +                       op, node, (unsigned long)node->size);
>  }
>  #else /* CONFIG_DEBUG_DEVRES */
>  #define set_node_dbginfo(node, n, s)   do {} while (0)
> --
> 2.17.0
>