linux-kernel - Re: [PATCH][V2] net: hinic: fix null pointer dereference on pointer hwdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181123.172158.1646655822759438209.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 17:21:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     aviad.krawczyk@...wei.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        sergei.shtylyov@...entembedded.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] net: hinic: fix null pointer dereference on
 pointer hwdev

From: Colin King <colin.king@...onical.com>
Date: Thu, 22 Nov 2018 10:05:01 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer hwdev is being dereferenced when declaring hwif , however, later
> on hwdev is being null checked, hence we have dereference before null
> check error. Fix this by assigning hwif and pdef only once hwdev has
> been null checked.
> 
> Detected by CoverityScan, CID#1485581 ("Dereference before null check")
> 
> Fixes: 4a61abb100c8 ("net-next/hinic:add rx checksum offload for HiNIC")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next.