linux-kernel - [PATCH] test_kmod: fix rmmod double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20181124050500.5257-1-mcgrof@kernel.org>
Date:   Fri, 23 Nov 2018 21:05:00 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     akpm@...ux-foundation.org
Cc:     rdunlap@...radead.org, linux-kernel@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>, stable@...r.kernel.org
Subject: [PATCH] test_kmod: fix rmmod double free

We double free the misc device string twice on rmmod, fix this.
Without this we cannot remove the module without crashing.

Cc: <stable@...r.kernel.org>      # for v4.12 and up
Reported-by: Randy Dunlap <rdunlap@...radead.org>
Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
---
 lib/test_kmod.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index e3ddd836491f..d82d022111e0 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1214,7 +1214,6 @@ void unregister_test_dev_kmod(struct kmod_test_device *test_dev)
 
 	dev_info(test_dev->dev, "removing interface\n");
 	misc_deregister(&test_dev->misc_dev);
-	kfree(&test_dev->misc_dev.name);
 
 	mutex_unlock(&test_dev->config_mutex);
 	mutex_unlock(&test_dev->trigger_mutex);
-- 
2.19.1