linux-kernel - Re: [PATCH 1/2] build_bug.h: remove negative-array fallback for BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kBpMG8kO+OQT_2TV7-=fU1Xifh6rtrhqDrO3Hjx-rqdw@mail.gmail.com>
Date:   Sat, 24 Nov 2018 09:14:03 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] build_bug.h: remove negative-array fallback for BUILD_BUG_ON()

On Fri, Nov 16, 2018 at 8:01 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Fri, Nov 16, 2018 at 12:19 AM, Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
> > The kernel can only be compiled with an optimization option (-O2, -Os,
> > or the currently proposed -Og). Hence, __OPTIMIZE__ is always defined
> > in the kernel source.
> >
> > A fallback for -O0 case is just hypothetical and pointless. Moreover,
> > commit 0bb95f80a38f ("Makefile: Globally enable VLA warning") enabled
> > -Wvla warning. The use of variable length arrays is banned.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Acked-by: Kees Cook <keescook@...omium.org>

Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

Cheers,
Miguel