linux-kernel - Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181125.101953.2072129230580561127.davem@davemloft.net>
Date:   Sun, 25 Nov 2018 10:19:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     deepa.kernel@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, viro@...iv.linux.org.uk, arnd@...db.de,
        y2038@...ts.linaro.org
Subject: Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from
 SOCK_RCVTSTAMP

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Sun, 25 Nov 2018 09:18:55 -0500

> The existing logic is as is for a reason. There is no need to change
> it to satisfy the main purpose of your patchset?
> 
> It is structured as one bit to test whether a timestamp is requested
> and another to select among two variants usec/nsec. Just add another
> layer of branching between new/old in cases where this distinction is
> needed.
> 
> Please avoid code churn unless needed.

+1