linux-kernel - Re: [PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP9ODKrTZm8FuRWLh+5NZSbpMh_yptotdoEgfrARHypUx8FkMg@mail.gmail.com>
Date:   Sun, 25 Nov 2018 21:10:51 -0200
From:   Otavio Salvador <otavio.salvador@...ystems.com.br>
To:     olof@...om.net
Cc:     Otavio Salvador <otavio@...ystems.com.br>, stefan.wahren@...e.com,
        Fabio Berton <fabio.berton@...ystems.com.br>,
        alexandre.torgue@...com, arnd@...db.de, eric@...olt.net,
        Tony Lindgren <tony@...mide.com>,
        Kernel development list <linux-kernel@...r.kernel.org>,
        Stefan Agner <stefan@...er.ch>,
        Russell King <linux@...linux.org.uk>, yannick.fertre@...com,
        linux-rockchip@...ts.infradead.org, horms+renesas@...ge.net.au,
        geert+renesas@...der.be, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options

Hello Olof,

On Sun, Nov 25, 2018 at 8:25 PM Olof Johansson <olof@...om.net> wrote:
> Thanks for these patches. I don't have a reason to _not_ enable
> systemd features, but would you mind providing a brief description of
> what's not working without this change? Is it completely broken, or is
> it just the random-UID featues that don't work, or something else?.
> Useful for others to know what's expected to break if someone turns
> them off, etc.

Thank you for your kindness reviewing this. I am not an experienced
Linux kernel contributor so I am going to do some mistakes during this
process.

We usually follow the required feature set listed on Gentoo wiki[1] as
it is usually up to date and avoids a lot of headaches for us when
dealing with boot issues with SystemD.

1. https://wiki.gentoo.org/wiki/Systemd#Kernel

Do you think mentioning where it has been taken from is enough?

> Also, I noticed you posted a series of 13 patches, which includes some
> dts files for rv1108, some network driver changes and some of these
> more generic defconfig changes. I would suggest that you split up your
> patches into independent series where possible, especially when they
> end up going to different subsystems. Providing suitable cover letters
> for the series when you post them is also useful to help reviewers by
> summarizing the series, including changes from last time it was
> posted, etc. Please address it to the superset of patch receivers on
> the series.

I can certainly improve it for the next submission. Should I split
them all and tag them v2 to easy it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750