linux-kernel - Re: [PATCH] debugobjects: avoid recursive calls with kmemleak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181126172148.GI33554@arrakis.emea.arm.com>
Date:   Mon, 26 Nov 2018 17:21:48 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Qian Cai <cai@....us>
Cc:     akpm@...ux-foundation.org, tglx@...utronix.de, longman@...hat.com,
        yang.shi@...ux.alibaba.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugobjects: avoid recursive calls with kmemleak

On Mon, Nov 26, 2018 at 11:53:43AM -0500, Qian Cai wrote:
> CONFIG_DEBUG_OBJECTS_RCU_HEAD does not play well with kmemleak due to
> recursive calls.
> 
> fill_pool
>   kmemleak_ignore
>     make_black_object
>       put_object
>         __call_rcu (kernel/rcu/tree.c)
>           debug_rcu_head_queue
>             debug_object_activate
>               debug_object_init
>                 fill_pool
>                   kmemleak_ignore
>                     make_black_object
>                       ...
> 
> Hence, adding SLAB_NOLEAKTRACE to kmem_cache_create() to not register a
> newly allocated debug objects at all.
> 
> Suggested-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Qian Cai <cai@....us>

Acked-by: Catalin Marinas <catalin.marinas@....com>