linux-kernel - Re: [PATCH] staging: pi433: add missing call to cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3f1023b-1df2-9748-3514-eb601697c725@gmail.com>
Date:   Mon, 26 Nov 2018 19:12:07 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, linux@...f-entwicklungen.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: add missing call to cdev_del()

On 11/26/18 7:01 PM, Dan Carpenter wrote:
> On Mon, Nov 26, 2018 at 06:53:55PM +0100, Michael Straube wrote:

>>   	retval = cdev_add(device->cdev, device->devt, 1);
>>   	if (retval) {
>>   		dev_dbg(device->dev, "register of cdev failed");
>> +		cdev_del(device->cdev);
>>   		goto cdev_failed;
> 
> No no...  That's not the right thing.  Do "goto del_cdev;" and add a
> label at the end.
> 
> del_cdev:
> 	cdev_del(device->cdev);
> 
> regards,
> dan carpenter
> 

Ah ok, I thought about that but was not sure. Thanks,
Michael