[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181126060505.vgu4serogh4brjpm@vireshk-i7>
Date: Mon, 26 Nov 2018 11:35:05 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Anson Huang <anson.huang@....com>
Cc: "rjw@...ysocki.net" <rjw@...ysocki.net>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 2/2] cpufreq: imx6q: save one condition block for normal
case of nvmem read
On 26-11-18, 02:59, Anson Huang wrote:
> Put return value checks of calling imx6ul_opp_check_speed_grading()
> into one block to save one condition block for normal case.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 8cb9683..9fedf62 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -405,9 +405,10 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
> if (of_machine_is_compatible("fsl,imx6ul") ||
> of_machine_is_compatible("fsl,imx6ull")) {
> ret = imx6ul_opp_check_speed_grading(cpu_dev);
> - if (ret == -EPROBE_DEFER)
> - return ret;
> if (ret) {
> + if (ret == -EPROBE_DEFER)
> + return ret;
> +
> dev_err(cpu_dev, "failed to read ocotp: %d\n",
> ret);
> return ret;
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
viresh
Powered by blists - more mailing lists