linux-kernel - Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126160602.1b5605df@gandalf.local.home>
Date:   Mon, 26 Nov 2018 16:06:02 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Andy Lutomirski <luto@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to
 enable function graph hooks

On Mon, 26 Nov 2018 20:30:49 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> > index f98063e273e5..477ff9412d26 100644
> > --- a/include/linux/ftrace.h
> > +++ b/include/linux/ftrace.h
> > @@ -749,6 +749,18 @@ typedef int (*trace_func_graph_ent_t)(struct ftrace_graph_ent *); /* entry */
> >  
> >  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> >  
> > +struct fgraph_ops {
> > +	trace_func_graph_ent_t		entryfunc;
> > +	trace_func_graph_ret_t		retfunc;  
> 
> > +	struct fgraph_ops __rcu		*next;
> > +	unsigned long			flags;
> > +	void				*private;
> > +#ifdef CONFIG_DYNAMIC_FTRACE
> > +	struct ftrace_ops_hash		local_hash;
> > +	struct ftrace_ops_hash		*func_hash;
> > +#endif  
> 
> Hmm, can we introduce these fields when we actually use it?

Sure.

> 
> BTW, would you have any idea for using private field?

I believe I answered this in another email.

-- Steve