linux-kernel - Re: [patch V2 13/28] x86/speculation: Reorder the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126222124.GQ4843@zn.tnic>
Date:   Mon, 26 Nov 2018 23:21:24 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jiri Kosina <jkosina@...e.cz>,
        Tom Lendacky <thomas.lendacky@....com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Casey Schaufler <casey.schaufler@...el.com>,
        Asit Mallick <asit.k.mallick@...el.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Jon Masters <jcm@...hat.com>,
        Waiman Long <longman9394@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dave Stewart <david.c.stewart@...el.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [patch V2 13/28] x86/speculation: Reorder the spec_v2 code

On Sun, Nov 25, 2018 at 07:33:41PM +0100, Thomas Gleixner wrote:
> Reorder the code so it is better grouped.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> ---
>  arch/x86/kernel/cpu/bugs.c |  168 ++++++++++++++++++++++-----------------------
>  1 file changed, 84 insertions(+), 84 deletions(-)

...

>  static const struct {
>  	const char *option;
>  	enum spectre_v2_mitigation_cmd cmd;
>  	bool secure;
>  } mitigation_options[] = {

Yeah, now that we have ssb_mitigation_options and v2_user_options also,
those should probably be called "spectre_v2_options" or something more
specific to have the code more clear which options the code is using...


> -	{ "off",               SPECTRE_V2_CMD_NONE,              false },
> -	{ "on",                SPECTRE_V2_CMD_FORCE,             true },
> -	{ "retpoline",         SPECTRE_V2_CMD_RETPOLINE,         false },
> -	{ "retpoline,amd",     SPECTRE_V2_CMD_RETPOLINE_AMD,     false },
> -	{ "retpoline,generic", SPECTRE_V2_CMD_RETPOLINE_GENERIC, false },
> -	{ "auto",              SPECTRE_V2_CMD_AUTO,              false },
> +	{ "off",		SPECTRE_V2_CMD_NONE,		  false },
> +	{ "on",			SPECTRE_V2_CMD_FORCE,		  true  },
> +	{ "retpoline",		SPECTRE_V2_CMD_RETPOLINE,	  false },
> +	{ "retpoline,amd",	SPECTRE_V2_CMD_RETPOLINE_AMD,	  false },
> +	{ "retpoline,generic",	SPECTRE_V2_CMD_RETPOLINE_GENERIC, false },
> +	{ "auto",		SPECTRE_V2_CMD_AUTO,		  false },
>  };

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.