linux-kernel - Re: linux-next: build warnings after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Nov 2018 17:51:35 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Kees Cook <keescook@...gle.com>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>, smfrench@...il.com,
        sprabhu@...hat.com, linux-cifs@...r.kernel.org,
        Linux-Next <linux-next@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the cifs tree

Hi Kees,

On Sun, 25 Nov 2018 21:48:10 -0800 Kees Cook <keescook@...gle.com> wrote:
>
> On Sun, Nov 25, 2018 at 4:52 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > On Sun, 25 Nov 2018 18:31:40 -0600 Steve French <smfrench@...il.com> wrote:  
> > >
> > > Both of those cases are intentional fallthroughs and there are
> > > existing comments in the code noting the reasons for them to
> > > fallthrough
> > >
> > > (also can see the reasoning for these in the commits which introduced
> > > them from Sachin c369c9a4a7c82) and dde2356c84662)  
> >
> > I am not questioning that :-)
> >
> > The gcc warning can be turned off by adding a /* fall through */
> > comment at the point the fall through happens.  Kees and others are
> > working on the several hundred other places that need annotating.  
> 
> Right. The goal is to avoid adding any _new_ cases of this. :)
> 
> > This one just popped up.  
> 
> It's already working! :) Thanks Stephen!

Actually this one was the product of how I filter out warnings ... it
was an old one, but the line numbers changed.   I have now started
ignoring these if just the line numbers change.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped