linux-kernel - Re: linux-next: build warning after merge of the f2fs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37611a15-da14-1796-5f4c-1278d46a4329@embeddedor.com>
Date:   Mon, 26 Nov 2018 16:36:36 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Kees Cook <keescook@...gle.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the f2fs tree



On 11/26/18 4:22 PM, Jaegeuk Kim wrote:
> On 11/27, Stephen Rothwell wrote:
[..]
> 
> Oh, thanks~
> Is this okay?
> 

Yep. This fix the warning. :)

Thanks, Jaegeuk
--
Gustavo

>  From 79e24f1509e5b6a07069be9cc8163969da78c57a Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk@...nel.org>
> Date: Mon, 26 Nov 2018 14:20:32 -0800
> Subject: [PATCH] f2fs: avoid build warn of fall_through
> 
> After merging the f2fs tree, today's linux-next build
>   (x86_64_allmodconfig) produced this warning:
> 
>   In file included from fs/f2fs/dir.c:11:
>   fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>   fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>      if (set)
>         ^
>   fs/f2fs/f2fs.h:2390:2: note: here
>     case FI_DATA_EXIST:
>     ^~~~
> 
>   Exposed by my use of -Wimplicit-fallthrough
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>   fs/f2fs/f2fs.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 26ad1de8641c..b3fe6803d4c6 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
>   	case FI_NEW_INODE:
>   		if (set)
>   			return;
> +		/* fall through */
>   	case FI_DATA_EXIST:
>   	case FI_INLINE_DOTS:
>   	case FI_PIN_FILE:
>