linux-kernel - Re: [PATCH] audit: remove some duplicated includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhSjBTVXAXKiNsgPDJUCsxPnd3DJVA1pjSQqN0ct=RaxJg@mail.gmail.com>
Date:   Mon, 26 Nov 2018 18:35:48 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     tiny.windzz@...il.com
Cc:     Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove some duplicated includes

On Mon, Nov 26, 2018 at 9:51 AM Yangtao Li <tiny.windzz@...il.com> wrote:
>
> audit.h and skbuff.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  kernel/audit.c | 3 ---
>  1 file changed, 3 deletions(-)

While there are two header files named audit.h, they are different
files as one lives in include/linux/audit.h, the other in
kernel/audit.h.  Granted, kernel/audit.h does include the
include/linux/audit.h file but it should be protected from multiple
inclusion by the _LINUX_AUDIT_H_ definition.

I currently prefer to keep both <linux/audit.h> and "audit.h" in
audit.c to help make the dependencies explicit in audit.c itself.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 2a8058764aa6..a677715891d0 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -62,11 +62,8 @@
>  #include <linux/pid.h>
>  #include <linux/slab.h>
>
> -#include <linux/audit.h>
> -
>  #include <net/sock.h>
>  #include <net/netlink.h>
> -#include <linux/skbuff.h>
>  #ifdef CONFIG_SECURITY
>  #include <linux/security.h>
>  #endif
> --
> 2.17.0

-- 
paul moore
www.paul-moore.com