linux-kernel - Re: [PATCH 2/9] iommu: rockchip: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3696101.6o5idU3W3V@phil>
Date:   Tue, 27 Nov 2018 00:37:07 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Simon Xue <xxm@...k-chips.com>,
        Daniel Kurtz <djkurtz@...omium.org>,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 2/9] iommu: rockchip: make it explicitly non-modular

Am Montag, 26. November 2018, 23:31:31 CET schrieb Paul Gortmaker:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/iommu/Kconfig:config ROCKCHIP_IOMMU
> drivers/iommu/Kconfig:  bool "Rockchip IOMMU Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> The bind/unbind/remove was already explicitly disabled in commit
> 98b72b94def9 ("iommu/rockchip: Prohibit unbind and remove").
> 
> Lets remove the remaining traces of  modular infrastructure, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Simon Xue <xxm@...k-chips.com>
> Cc: Daniel Kurtz <djkurtz@...omium.org>
> Cc: Jeffy Chen <jeffy.chen@...k-chips.com>
> Cc: iommu@...ts.linux-foundation.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-rockchip@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Heiko Stuebner <heiko@...ech.de>