linux-kernel - Re: [PATCH] fsnotify: remove some duplicated includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhRX8vs42AYaQRAwqs1VonJWai75fcsHogn17FxDT431_g@mail.gmail.com>
Date:   Mon, 26 Nov 2018 18:37:43 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     tiny.windzz@...il.com
Cc:     Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsnotify: remove some duplicated includes

On Mon, Nov 26, 2018 at 9:54 AM Yangtao Li <tiny.windzz@...il.com> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  kernel/audit_fsnotify.c | 2 --
>  1 file changed, 2 deletions(-)

I currently prefer to keep things as-is, see my response to your previous patch.

> diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
> index fba78047fb37..5b54386a9edf 100644
> --- a/kernel/audit_fsnotify.c
> +++ b/kernel/audit_fsnotify.c
> @@ -16,10 +16,8 @@
>   */
>
>  #include <linux/kernel.h>
> -#include <linux/audit.h>
>  #include <linux/kthread.h>
>  #include <linux/mutex.h>
> -#include <linux/fs.h>
>  #include <linux/fsnotify_backend.h>
>  #include <linux/namei.h>
>  #include <linux/netlink.h>
> --
> 2.17.0
>


-- 
paul moore
www.paul-moore.com