linux-kernel - Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181126164002.16e2e924529f52fb4d46d2f4@kernel.org>
Date:   Mon, 26 Nov 2018 16:40:02 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Andy Lutomirski <luto@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RFC][PATCH 08/14] function_graph: Remove unused
 task_curr_ret_stack()

On Wed, 21 Nov 2018 20:27:16 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> The static inline function task_curr_ret_stack() is unused, remove it.

This looks able to be applied without this series. I think we should
apply this to for-next branch?

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks,


> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
>  include/linux/ftrace.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index 477ff9412d26..5544df21a886 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -819,11 +819,6 @@ extern void ftrace_graph_init_task(struct task_struct *t);
>  extern void ftrace_graph_exit_task(struct task_struct *t);
>  extern void ftrace_graph_init_idle_task(struct task_struct *t, int cpu);
>  
> -static inline int task_curr_ret_stack(struct task_struct *t)
> -{
> -	return t->curr_ret_stack;
> -}
> -
>  static inline void pause_graph_tracing(void)
>  {
>  	atomic_inc(&current->tracing_graph_pause);
> @@ -847,11 +842,6 @@ static inline int register_ftrace_graph(struct fgraph_ops *ops);
>  }
>  static inline void unregister_ftrace_graph(struct fgraph_ops *ops) { }
>  
> -static inline int task_curr_ret_stack(struct task_struct *tsk)
> -{
> -	return -1;
> -}
> -
>  static inline unsigned long
>  ftrace_graph_ret_addr(struct task_struct *task, int *idx, unsigned long ret,
>  		      unsigned long *retp)
> -- 
> 2.19.1
> 
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>