linux-kernel - Re: linux-next: build warnings after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Nov 2018 11:52:47 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Steve French <smfrench@...il.com>
Cc:     Sachin Prabhu <sprabhu@...hat.com>,
        CIFS <linux-cifs@...r.kernel.org>, keescook@...gle.com,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the cifs tree

Hi Steve,

On Sun, 25 Nov 2018 18:31:40 -0600 Steve French <smfrench@...il.com> wrote:
>
> Both of those cases are intentional fallthroughs and there are
> existing comments in the code noting the reasons for them to
> fallthrough
> 
> (also can see the reasoning for these in the commits which introduced
> them from Sachin c369c9a4a7c82) and dde2356c84662)

I am not questioning that :-)

The gcc warning can be turned off by adding a /* fall through */
comment at the point the fall through happens.  Kees and others are
working on the several hundred other places that need annotating.

This one just popped up.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped