linux-kernel - Re: [PATCH 2/2] ic3: master: off by one in mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181126094643.6b1f05cd@bbrezillon>
Date:   Mon, 26 Nov 2018 09:46:43 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] ic3: master: off by one in mode_show()

On Fri, 23 Nov 2018 10:15:05 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:

> This should be >= ARRAY_SIZE() to avoid reading one element beyond the
> end of the array.
> 
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Queued to i3c/next.

Thanks,

Boris

> ---
>  drivers/i3c/master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index bda4b9613e53..c39f89d2deba 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -475,7 +475,7 @@ static ssize_t mode_show(struct device *dev,
>  
>  	i3c_bus_normaluse_lock(i3cbus);
>  	if (i3cbus->mode < 0 ||
> -	    i3cbus->mode > ARRAY_SIZE(i3c_bus_mode_strings) ||
> +	    i3cbus->mode >= ARRAY_SIZE(i3c_bus_mode_strings) ||
>  	    !i3c_bus_mode_strings[i3cbus->mode])
>  		ret = sprintf(buf, "unknown\n");
>  	else