linux-kernel - Re: [PATCH] printk: deduplicate print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d01dbc9d-494c-79e2-0d16-918f56d0e285@i-love.sakura.ne.jp>
Date:   Mon, 26 Nov 2018 19:21:13 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: deduplicate print_prefix() calls

On 2018/11/26 16:56, Sergey Senozhatsky wrote:
> Or we can "copy" the value of printk_time and use it in print_prefix(),
> and we will pick up an updated value next time we do msg_print_text()?

Yes, that is also possible. But it would be better to pass as a function
argument to print_prefix() rather than adding a global variable, and omit
calling print_time() if the passed argument is false. But however, removing
print_prefix() reduces object size, for it eliminates redundant instructions.