linux-kernel - Re: [PATCH] Little memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Nov 2018 13:32:47 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     David CARLIER <devnexen@...il.com>
Cc:     linux-kernel@...r.kernel.org, alexander.shishkin@...ux.intel.com,
        aryabinin@...tuozzo.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH] Little memset_explicit optimisation

On Sat, Nov 24, 2018 at 03:35:05PM +0000, David CARLIER wrote:
> Subject: [PATCH] memzero_explicit, optimisation for size.
> 
> 
> Using the return value of memset for save/load sake.


It's mangled, you, perhaps, need to use

  `git format-patch ...; git send-email ...`

for sake of correctness.

On top of that, same comment as per previous attempt.
Btw, you need to use versioning (hint: `git format-patch -v ` IIRC).

> 
> 
> Signed-off-by: David Carlier <devnexen@...il.com>
> 
> ---
> 
>  lib/string.c | 2 +-
> 
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/lib/string.c b/lib/string.c
> 
> index 38e4ca08e757..92da04a0213b 100644
> 
> --- a/lib/string.c
> 
> +++ b/lib/string.c
> 
> @@ -720,7 +720,7 @@ EXPORT_SYMBOL(memset);
> 
>   */
> 
>  void memzero_explicit(void *s, size_t count)
> 
>  {
> 
> - memset(s, 0, count);
> 
> + s = memset(s, 0, count);
> 
>   barrier_data(s);
> 
>  }
> 
>  EXPORT_SYMBOL(memzero_explicit);
> 
> -- 
> 
> 2.19.1

-- 
With Best Regards,
Andy Shevchenko