lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181126135632.GA25835@quack2.suse.cz>
Date:   Mon, 26 Nov 2018 14:56:32 +0100
From:   Jan Kara <jack@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.com>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: clean up indentation issue, replace spaces with tab

On Fri 23-11-18 16:40:53, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a statement that is indented with spaces, replace it with
> a tab.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/jbd2/transaction.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index c0b66a7a795b..4af8ff17ad5c 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -910,7 +910,7 @@ do_get_write_access(handle_t *handle, struct journal_head *jh,
>  	 * this is the first time this transaction is touching this buffer,
>  	 * reset the modified flag
>  	 */
> -       jh->b_modified = 0;
> +	jh->b_modified = 0;
>  
>  	/*
>  	 * If the buffer is not journaled right now, we need to make sure it
> -- 
> 2.19.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ