linux-kernel - Re: [PATCH v3 0/2] x86/kvm: Enable MCE injection in the guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64d0e75f-f292-7e63-dd66-4e05d4afed5b@redhat.com>
Date:   Mon, 26 Nov 2018 17:41:21 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Borislav Petkov <bp@...en8.de>, KVM <kvm@...r.kernel.org>
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Tony Luck <tony.luck@...el.com>,
        Yazen Ghannam <Yazen.Ghannam@....com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/2] x86/kvm: Enable MCE injection in the guest

On 14/11/18 19:15, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> Hi all,
> 
> here's a rediff ontop of -rc2. No changes, only added Yazen's Tested-by.
> 
> Please queue,
> thx.
> 
> Changelog:
> ==========
> 
> v2:
> 
> here's v2, dropping patch 3 and incorporating hopefully all of Radim's
> feedback.
> 
> v1:
> 
> there's this mce-inject.ko module in the kernel which allows for
> injecting real MCEs and thus test the MCE handling code.
> 
> It is doubly useful to be able to inject same MCEs in a guest so that
> testing of the MCE handling code can happen even easier/faster. In order
> to be able to do that on an AMD guest, we need to emulate some bits
> and pieces like the HWCR[McStatusWrEn] bit which allows writes to the
> MCi_STATUS registers without a #GP.
> 
> The below does that and with it I'm able to properly inject MCEs in said
> guest.
> 
> --
> 
> Borislav Petkov (2):
>   kvm/x86: Move MSR_K7_HWCR to svm.c
>   x86/kvm: Implement MSR_HWCR support
> 
>  arch/x86/kvm/svm.c | 20 ++++++++++++++++++++
>  arch/x86/kvm/x86.c | 46 +++++++++++++++++++++++++++++++---------------
>  2 files changed, 51 insertions(+), 15 deletions(-)
> 

Queued, thanks.

Paolo