linux-kernel - Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1543358936.4223.3.camel@kernel.org>
Date:   Tue, 27 Nov 2018 16:48:56 -0600
From:   Tom Zanussi <zanussi@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     rostedt@...dmis.org, tglx@...utronix.de, mhiramat@...nel.org,
        vedang.patel@...el.com, bigeasy@...utronix.de,
        joel@...lfernandes.org, mathieu.desnoyers@...icios.com,
        julia@...com, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org, kernel-team@....com
Subject: Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and
 save action

Hi Namhyung,

On Fri, 2018-11-23 at 16:01 +0900, Namhyung Kim wrote:
> On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote:
> > From: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > 
> > 

[snip]

> > -
> > -	update_max_vars(hist_data, elt, rbe, rec);
> > +	if (update_track_val(hist_data, elt, data, var_ref_vals))
> > +		update_save_vars(hist_data, elt, rbe, rec);
> 
> ... and then it should look like:
> 
> 	if (check_track_val()) {
> 		save_track_val();
> 		update_save_vars();
> 	}
> 
> I also think update_save_vars() also needs to be renamed something
> like save_track_vars() or save_trace_data().
> 

Yes, this is much nicer - I've made these changes and more for v8. 
Thanks for the input.

Tom