linux-kernel - Re: [PATCH] selftests: add TPM 2.0 tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181127231348.GB26051@linux.intel.com>
Date:   Tue, 27 Nov 2018 15:13:48 -0800
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Joey Pabalinas <joeypabalinas@...il.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Tadeusz Struk <tadeusz.struk@...el.com>,
        Shuah Khan <shuah@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH] selftests: add TPM 2.0 tests

On Tue, Nov 27, 2018 at 12:53:07PM -1000, Joey Pabalinas wrote:
> On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote:
> > > +    def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1):
> > > +        fmt = '>HII IIH16sHBHH'
> > > +        cmd = struct.pack(fmt,
> > > +                          TPM2_ST_NO_SESSIONS,
> > > +                          struct.calcsize(fmt),
> > > +                          TPM2_CC_START_AUTH_SESSION,
> > > +                          TPM2_RH_NULL,
> > > +                          TPM2_RH_NULL,
> > > +                          16,
> > > +                          '\0' * 16,
> > > +                          0,
> > > +                          session_type,
> > > +                          TPM2_ALG_NULL,
> > > +                          name_alg)
> > > +
> > > +        return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
> > > +
> > > +    def __calc_pcr_digest(self, pcrs, bank_alg = TPM2_ALG_SHA1,
> > > +                          digest_alg = TPM2_ALG_SHA1):
> > > +        x = []
> > 
> > Is there a reason for using `'\0' * 16` there instead of just 0?
> 
> Nevermind, I keep forgetting that the * operator on strings performs
> repetition. I've been programming too much C lately, it seems.
> 
> Acked-By: Joey Pabalinas <joeypabalinas@...il.com>

Thank you! Would be good to have these merged to the kernel tree so that
one can include both functionality and test case when needed to the
patch set.

/Jarkko