linux-kernel - Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181127075750.GA929@kroah.com>
Date:   Tue, 27 Nov 2018 08:57:50 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Yang Xiao <YangX92@...mail.com>
Cc:     "r.weclawski@...il.com" <r.weclawski@...il.com>,
        "straube.linux@...il.com" <straube.linux@...il.com>,
        "santhameena13@...il.com" <santhameena13@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "jananis37@...il.com" <jananis37@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

On Tue, Nov 27, 2018 at 07:29:07AM +0000, Yang Xiao wrote:
> From: Young_X <YangX92@...mail.com>

Please use your "full" name like you did in your from: line of your
email

> 
>     The error at line 3267 was the result of an off-by-one error in
>     a for loop in line 3253.
>     If condition in line 3254 never satisfies, then the value of
>     pstat->aid is NUM_STA+1. This will lead to out-of-bound access
>     in line 3267.

Why is this indented?  No need for that.

Can you fix that up and resend?

thanks,

greg k-h