linux-kernel - Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181127083427.GS2970@unbuntlaptop>
Date:   Tue, 27 Nov 2018 11:34:27 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Yang Xiao <YangX92@...mail.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "r.weclawski@...il.com" <r.weclawski@...il.com>,
        "straube.linux@...il.com" <straube.linux@...il.com>,
        "santhameena13@...il.com" <santhameena13@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "jananis37@...il.com" <jananis37@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

On Tue, Nov 27, 2018 at 08:29:05AM +0000, Yang Xiao wrote:
> Hi,
> 
> See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an 
> off-by-one mistake in core/rtw_mlme_ext.c") for detail.
> 
> I don't know how can you make sure that line 3254 can be true in the for 
> loop.  If the condition never satisfies, then there is an off-by-one 
> access in line 3267.
> 
> If you can prove it, then the patch is unnecessary.
> 

Ugh...  Patch ef9209b642f isn't right.  :(

Do you want to send a patch to change that back to the way it was.  If
not then I can do it.

regards,
dan carpenter