linux-kernel - Re: [PATCH] libceph: fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54c1bcc5-6df5-ba24-2774-98f6333c57b3@cogentembedded.com>
Date:   Tue, 27 Nov 2018 11:47:56 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Pan Bian <bianpan2016@....com>, Ilya Dryomov <idryomov@...il.com>,
        "Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     ceph-devel@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libceph: fix use after free

Hello!

On 27.11.2018 10:02, Pan Bian wrote:

> The function ceph_monc_handle_map calls kfree(old) to free the old
> monitor map, old points to monc->monmap. However, after that, it reads
> monc->monmap->epoch and passes it to __ceph_monc_got_map. This result in
> a use-after-free bug. The patch moves the free operation after the call
> to __ceph_monc_got_map.
> 
> Fixes: 82dcabad750("libceph: revamp subs code, switch to SUBSCRIBE2

    Space needed before (.

> protocol")

    Never break up the commit summary in this tag.

> Signed-off-by: Pan Bian <bianpan2016@....com>
[...]

MBR, Sergei