linux-kernel - Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181127084928.GO3088@unbuntlaptop>
Date:   Tue, 27 Nov 2018 11:49:28 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Yang Xiao <YangX92@...mail.com>
Cc:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jananis37@...il.com" <jananis37@...il.com>,
        "r.weclawski@...il.com" <r.weclawski@...il.com>,
        "santhameena13@...il.com" <santhameena13@...il.com>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

On Tue, Nov 27, 2018 at 08:41:53AM +0000, Yang Xiao wrote:
> Okay. I can send a patch to revert ef9209b642f.
> 
> But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid 
> - 1] == NULL)" can satisfies in the for loop?

->max_num_sta is either set in _rtw_init_sta_priv() or rtw_set_beacon().
You can see that it's <= MAX_STA.

regards,
dan carpenter