linux-kernel - Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181127085448.GA29599@kroah.com>
Date:   Tue, 27 Nov 2018 09:54:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Rodolfo Giometti <giometti@...eenne.com>
Cc:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        richardcochran@...il.com, sudipm.mukherjee@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH -next] pps: using ERR_PTR instead of NULL while
 pps_register_source fails

On Tue, Nov 27, 2018 at 09:36:38AM +0100, Rodolfo Giometti wrote:
> On 27/11/2018 08:34, Greg KH wrote:
> > On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote:
> > > On 26/11/2018 11:24, YueHaibing wrote:
> > > > pps_register_source() has keeps error codes in a local variable,
> > > > but it does not make use of the code. This patch let it return
> > > > the errcode in case of failure.
> > > > 
> > > > Suggested-by: Richard Cochran <richardcochran@...il.com>
> > > > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > > 
> > > Acked-by: Rodolfo Giometti <giometti@...eenne.com>
> > 
> > You are the maintainer of this file, shouldn't you be the one sending it
> > off to Linus or putting it in your tree somewhere?
> 
> This subsystem never had an official tree and in the past I simply acked the
> code and patches was taken by you (or other maintainers) for inclusion... I
> know it's not usual by it worked as is since right now!
> 
> However if you prefer having an official tree even for LinuxPPS I can do it
> and then sending my pull requests to Linus! Just let me know what is better
> for you! :-)

Ok, I'll take it now, thanks.

greg k-h