linux-kernel - Re: [PATCH] tools lib traceevent: Fix compile warnings in tools/lib/traceevent/event-parse.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126200454.GG18491@kernel.org>
Date:   Mon, 26 Nov 2018 17:04:54 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Fix compile warnings in
 tools/lib/traceevent/event-parse.c

Em Thu, Nov 22, 2018 at 01:29:37PM +0200, Adrian Hunter escreveu:
> Fix following warnings:

Steven, any problem if I apply these? I think I've hit these warnings on
Clear Linux too.

- Arnaldo
 
> event-parse.c: In function ‘tep_find_event_by_name’:
> event-parse.c:3521:21: warning: ‘event’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   pevent->last_event = event;
>   ~~~~~~~~~~~~~~~~~~~^~~~~~~
>   CC       ui/gtk/hists.o
>   LINK     plugin_mac80211.so
>   CC       nlattr.o
> event-parse.c: In function ‘tep_data_lat_fmt’:
> event-parse.c:5200:4: warning: ‘migrate_disable’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     trace_seq_printf(s, "%d", migrate_disable);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> event-parse.c:5207:4: warning: ‘lock_depth’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     trace_seq_printf(s, "%d", lock_depth);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   LINK     plugin_sched_switch.so
>   LINK     plugin_function.so
>   LINK     plugin_xen.so
> event-parse.c: In function ‘tep_event_info’:
> event-parse.c:5047:7: warning: ‘len_arg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>        trace_seq_printf(s, format, len_arg, (char)val);
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> event-parse.c:4884:6: note: ‘len_arg’ was declared here
>   int len_arg;
>       ^~~~~~~
> event-parse.c:4338:11: warning: ‘vsize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>      val = tep_read_number(pevent, bptr, vsize);
>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> event-parse.c:4224:6: note: ‘vsize’ was declared here
>   int vsize;
>       ^~~~~
> 
> $ gcc --version
>   gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/lib/traceevent/event-parse.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 3692f29fee46..fbd6d6813fab 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -3498,7 +3498,7 @@ struct tep_event_format *
>  tep_find_event_by_name(struct tep_handle *pevent,
>  		       const char *sys, const char *name)
>  {
> -	struct tep_event_format *event;
> +	struct tep_event_format *event = NULL;
>  	int i;
>  
>  	if (pevent->last_event &&
> @@ -4221,7 +4221,7 @@ static struct tep_print_arg *make_bprint_args(char *fmt, void *data, int size, s
>  	unsigned long long ip, val;
>  	char *ptr;
>  	void *bptr;
> -	int vsize;
> +	int vsize = 0;
>  
>  	field = pevent->bprint_buf_field;
>  	ip_field = pevent->bprint_ip_field;
> @@ -4881,7 +4881,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e
>  	char format[32];
>  	int show_func;
>  	int len_as_arg;
> -	int len_arg;
> +	int len_arg = 0;
>  	int len;
>  	int ls;
>  
> @@ -5146,8 +5146,8 @@ void tep_data_lat_fmt(struct tep_handle *pevent,
>  	static int migrate_disable_exists;
>  	unsigned int lat_flags;
>  	unsigned int pc;
> -	int lock_depth;
> -	int migrate_disable;
> +	int lock_depth = 0;
> +	int migrate_disable = 0;
>  	int hardirq;
>  	int softirq;
>  	void *data = record->data;
> -- 
> 2.17.1

-- 

- Arnaldo