linux-kernel - Re: [PATCH 7/9] iommu: tegra-gart: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181127141803.GA10560@ulmo>
Date:   Tue, 27 Nov 2018 15:18:03 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Hiroshi Doyu <hdoyu@...dia.com>,
        Stephen Warren <swarren@...dotorg.org>,
        Alexandre Courbot <gnurou@...il.com>,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 7/9] iommu: tegra-gart: make it explicitly non-modular

On Mon, Nov 26, 2018 at 05:31:36PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/iommu/Kconfig:config TEGRA_IOMMU_GART
> drivers/iommu/Kconfig:  bool "Tegra GART IOMMU Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> 
> We replace module.h with moduleparam.h since the file does actually
> declare some module_param() and the easiest way to keep back
> compatibility with existing use cases is to leave it as-is for now.
> 
> The init function was missing an __init annotation, so it was added.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Hiroshi Doyu <hdoyu@...dia.com>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: iommu@...ts.linux-foundation.org
> Cc: linux-tegra@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/iommu/tegra-gart.c | 37 +++++++------------------------------
>  1 file changed, 7 insertions(+), 30 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)