linux-kernel - Re: [PATCH 3/3] x86/cpuid: Make cpuinfo_x86.x86_model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Nov 2018 17:55:49 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        linux-edac@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 3/3] x86/cpuid: Make cpuinfo_x86.x86_model_id global

On Wed, Nov 14, 2018 at 11:29 PM Borislav Petkov <bp@...en8.de> wrote:
>
> From: Borislav Petkov <bp@...e.de>
>
> ... and __ro_after_init. Since the brand string is being read earlier
> now, in early_identify_cpu(), get_model_name() needs to read out the
> extended CPUID level for the brand string. This is temporary only, until
> the full CPUID read out has been added.

>  drivers/platform/x86/intel_ips.c     |  6 +++---
>  15 files changed, 35 insertions(+), 35 deletions(-)



> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 225638a1b09e..4309f198cbad 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1367,11 +1367,11 @@ static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
>         else
>                 ips->turbo_toggle_allowed = false;
>
> -       if (strstr(boot_cpu_data.x86_model_id, "CPU       M"))
> +       if (strstr(x86_model_id, "CPU       M"))
>                 limits = &ips_sv_limits;
> -       else if (strstr(boot_cpu_data.x86_model_id, "CPU       L"))
> +       else if (strstr(x86_model_id, "CPU       L"))
>                 limits = &ips_lv_limits;
> -       else if (strstr(boot_cpu_data.x86_model_id, "CPU       U"))
> +       else if (strstr(x86_model_id, "CPU       U"))
>                 limits = &ips_ulv_limits;
>         else {
>                 dev_info(ips->dev, "No CPUID match found.\n");

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

for PDx86 bits

--
With Best Regards,
Andy Shevchenko