linux-kernel - RE: [PATCH] ASoC: max98373: Added max98373

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Nov 2018 17:53:03 +0000
From:   Ryan Lee <RyanS.Lee@...imintegrated.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Grant Grundler <grundler@...omium.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Benson Leung <bleung@...omium.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

>-----Original Message-----
>From: Mark Brown <broonie@...nel.org>
>Sent: Tuesday, November 27, 2018 3:51 AM
>To: Ryan Lee <RyanS.Lee@...imintegrated.com>
>Cc: Liam Girdwood <lgirdwood@...il.com>; Jaroslav Kysela
><perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Grant Grundler
><grundler@...omium.org>; Kuninori Morimoto
><kuninori.morimoto.gx@...esas.com>; Benson Leung
><bleung@...omium.org>; alsa-devel@...a-project.org; linux-
>kernel@...r.kernel.org
>Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp
>reset
>
>On Mon, Nov 26, 2018 at 06:46:05PM +0000, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
>> ---
>
>This really needs a changelog to explain what is going on here, and we need
>some more documentation in the code.  It is *extremely* unusual to have to
>poll for reset like this, and if the failure mode is I/O errors that's going to be
>pretty painful.
OK. I agree that this is very unusual. I wanted to make this code change very conservative and this caused unusual overhead.
Let me fix this.