linux-kernel - Re: [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181127201222.GA3095@unbuntlaptop>
Date:   Tue, 27 Nov 2018 23:12:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Cathy Avery <cavery@...hat.com>
Cc:     martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com, hch@....de,
        jgill@...are.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, emilne@...hat.com,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls
 to free_irq during unload

On Tue, Nov 27, 2018 at 02:28:53PM -0500, Cathy Avery wrote:
> Currently pvscsi_remove calls free_irq more than once as
> pvscsi_release_resources and __pvscsi_shutdown both call
> pvscsi_shutdown_intr. This results in a 'Trying to free
> already-free IRQ' warning and stack trace. To solve the problem
> pvscsi_shutdown_intr has been moved out of pvscsi_release_resources.
> 
> Signed-off-by: Cathy Avery <cavery@...hat.com>
> Reviewed-by: Ewan D. Milne <emilne@...hat.com>

That bug has been there since the driver was introduced in 2009.  It's
so amazing that no one has fixed it until now...

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter