linux-kernel - Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9a0cefe-1c8e-2d34-802a-d5f8de01df7b@gmail.com>
Date:   Wed, 28 Nov 2018 13:47:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Yangtao Li <tiny.windzz@...il.com>, computersforpeace@...il.com,
        gregory.0xf0@...il.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, treding@...dia.com,
        olof@...om.net, arnd@...db.de
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node
 reference



On 11/24/18 6:52 AM, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node returned by it
> and that reference needs to be dropped by its caller. soc_is_brcmstb()
> doesn't do that, so fix it.
> 
> [treding: slightly rewrite to avoid inline comparison]
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Applied to drivers/next, thanks!
-- 
Florian